Skip to content

Explicitly import Meshes.Geometry #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaLampert merged 5 commits into from
Oct 24, 2024
Merged

Explicitly import Meshes.Geometry #118

JoshuaLampert merged 5 commits into from
Oct 24, 2024

Conversation

@mikeingold
Copy link
Collaborator

@mikeingold mikeingold commented Oct 23, 2024 •
edited
Loading

Changes

  • Explicitly import Meshes.Geometry. This is a frequently-used reference with a fairly obvious namespace source, and being able to reference it implicitly will reduce function signature line lengths.
  • Update method signatures, eliminating unnecessary where clauses. I'm told that there's no functional/performance difference between a function argument being f(x::SuperType) vs f(x::ST) where {ST <: SuperType}.

@mikeingold
Copy link
Collaborator Author

mikeingold commented Oct 23, 2024

This partially conflicts with #114 (as-is at the moment). I wanted to shrink the line length of _units to fit it into a single-line definition and had this idea, but implementing this for the whole package felt out-of-scope for that PR. If this PR is merged, I'll update the #114 branch to merge it with these changes.

@codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@93a9b1d). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage        ?   95.75%           
=======================================
  Files           ?       17           
  Lines           ?      259           
  Branches        ?        0           
=======================================
  Hits            ?      248           
  Misses          ?       11           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeingold
Copy link
Collaborator Author

mikeingold commented Oct 23, 2024

I'm continuing to consider condensing all of our function definitions to use single-line headers, but this currently would still require splitting somewhere into multiple lines to respect the 92-column soft limit. I'm hoping that this change would also make that change more practical.

@mikeingold mikeingold marked this pull request as ready for review October 23, 2024 22:48
@JoshuaLampert JoshuaLampert merged commit 6c8cd1f into main Oct 24, 2024
@JoshuaLampert JoshuaLampert deleted the using-Geometry branch October 24, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaLampert JoshuaLampert JoshuaLampert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikeingold @JoshuaLampert